Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic coin selection strategies #195

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

RodriFS
Copy link
Contributor

@RodriFS RodriFS commented Jun 16, 2023

  • Frontend for the automatic coin selection
  • Everything is displayed in BTC and USD
  • Added a variable to hide this feature until we deploy the custom backend

Notes:
I commented the "Tolerance" feature because I'm not sure it's necessary after all. If we need it in the future we can uncomment it, else, we can just remove it from here and the backend.

src/Services/LightningService.cs Outdated Show resolved Hide resolved
src/Services/CoinSelectionService.cs Outdated Show resolved Hide resolved
src/Shared/UTXOSelectorModal.razor Outdated Show resolved Hide resolved
@RodriFS RodriFS requested a review from markettes June 21, 2023 08:31
@RodriFS RodriFS force-pushed the feature-automatic-coin-selection-strategies branch from 7853253 to 66fb018 Compare June 21, 2023 08:38
Copy link
Contributor

@markettes markettes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RodriFS RodriFS merged commit 5bd1c2d into main Jun 21, 2023
1 check passed
@RodriFS RodriFS deleted the feature-automatic-coin-selection-strategies branch June 21, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants